Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create nikcircle.go #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create nikcircle.go #57

wants to merge 2 commits into from

Conversation

StudioDeurbel
Copy link

i want to add this so i can prove that i can have my own ascii.live animation gif :)

@hugomd
Copy link
Owner

hugomd commented Jan 5, 2025

Related to #58

hugomd
hugomd reviewed Jan 5, 2025
View reviewed changes
frames/nikcircle.go
var Nikcircle = DefaultFrameType(Nikcircleframes)

var Nikcircleframes = []string{
@@@@@@
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a missing backtick (`) and won't compile.

I recommend adding a few more frames as well, as this won't actually animate with one frame.

hugomd
hugomd requested changes Jan 5, 2025
View reviewed changes
Copy link
Owner

@hugomd hugomd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising a PR. Can you combine this with #58, so I don't have to manage an extra PR? 🙏🏻

@hugomd hugomd mentioned this pull request Jan 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugomd hugomd hugomd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StudioDeurbel @hugomd